fixed to work with newer MH and perl5. Added trending of barom the wm2 d... #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a valid change to me. Any of the other developers who plans to test this out, or do we merge into master before the next stable release? |
|
I am doubtful of finding more beta testers for this. I trust Sean's coding skills, I vote merge. |
krkeegan
added a commit
that referenced
this pull request
Mar 27, 2014
fixed to work with newer MH and perl5. Added trending of barom the wm2 d...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to get my wm2 to work on the newer MH on git in master. It worked fine on old mh perl4 system.
Let me know any patterns I used are going to cause any problems or if other fixes need to be made and I will adjust till this is ready to merge.
Fixes.
The cron was broken and caused errors.
The serial reading was broken added a chr() to fix the casting that does not work in perl5
The debugging flag was changed to lower case 'weather' to match other modules usage
Added
Barometer trending analysis